apotdevin / thunderhub

ThunderHub LND Lightning Node Manager in your Browser
https://www.thunderhub.io/
MIT License
412 stars 84 forks source link

Confusing suffix 'm' - for "mega" #189

Open Kixunil opened 3 years ago

Kixunil commented 3 years ago

Describe the problem/bug When viewing the list of channels, there's "m" suffix used. It seems it's supposed to mean "mega", however "m" means "milli", capital "M" means "mega".

Your environment

To Reproduce Steps to reproduce the behavior:

  1. Create at least 1M sat channel
  2. Look into channel list
  3. See confusing description

Expected behavior Capital "M" is shown for "mega"

Actual behavior Lower case "m" is shown for mega

Screenshots/Links I don't want to disclose balances, hiding values hides suffixes too

Additional context https://en.wikipedia.org/wiki/Metric_prefix

apotdevin commented 3 years ago

Good point, I believe this is coming directly from the number formatting lib I'm using and they use the m for million? Will look into how to override this.

Kixunil commented 3 years ago

I guess filing a bug report against that lib also makes sense.