Multi-account SSO - Githubissues

Kixunil commented 3 years ago

Is your feature request related to a problem? Please describe. SSO is currently possible with only one account - node. The change of base path to be baked-in caused breakage of the ability to use two nodes (mainnet, regtest) under a single user. Allowing SSO to be used with multiple nodes would mitigate the issue.

Describe the solution you'd like Long term I'd like to enable multiple users to use SSO for possibly different sets of nodes, so it'd be nice to keep it in mind. Short term allowing a single user to login using SSO and control all specified nodes is sufficient. I think that showing one of the nodes ("main") after login and having a UI element to select a different node would be reasonable.

Describe alternatives you've considered

Select the node before logging-in - this has a problem that to switch a node one has to logout first
A different SSO token for each node - this would require ThunderHub to appear as multiple applications (not a big deal), what's worse, it'd probably cause problems if user opens more than one node in a new tab

Provide examples I'm not an UI expert so IDK how to best design the switcher.

Additional context See also #190

Kixunil commented 3 years ago

I would like to ask for this to be assigned higher priority if possible. I'm unable to update until this is resolved, which also means having to keep up with vulnerability fixes manually.

apotdevin commented 3 years ago

I'll look into it this week!

apotdevin commented 3 years ago

Hey! So this PR will enable multi node SSO authentication https://github.com/apotdevin/thunderhub/pull/212

Would be great if you can test it out. I documented the config here but let me know if theres anything confusing!

Kixunil commented 3 years ago

Great! It'll take me a while to test it properly as I will need to also rewrite a few things. I hope I can do it at worst in a few days.

apotdevin / thunderhub

Multi-account SSO #202