apotdevin / thunderhub

ThunderHub LND Lightning Node Manager in your Browser
https://www.thunderhub.io/
MIT License
413 stars 84 forks source link

[UPDATE] Change the default received onchain address to taproot #542

Closed twofaktor closed 1 year ago

twofaktor commented 1 year ago

Since v0.15.0, LND uses taproot addresses by default

This PR makes changes accordingly to match this update.

Src: https://github.com/lightningnetwork/lnd/blob/v0-16-4-branch/docs/release-notes/release-notes-0.15.1.md#taproot https://github.com/lightningnetwork/lnd/pull/6810 https://github.com/lightningnetwork/lnd/issues/6666 https://github.com/lightningnetwork/lnd/pull/6633

Ref: https://github.com/apotdevin/thunderhub/commit/cb61a5073a0f67730704ffa55abb214fde8b0ec4

twofaktor commented 1 year ago

@secondl1ght @apotdevin could you review this?

apotdevin commented 1 year ago

Looks good! Thanks for the PR!

apotdevin commented 1 year ago

@twofaktor can you run npm run lint to fix the build pipeline? It should be ready to go after this

twofaktor commented 1 year ago

@twofaktor can you run npm run lint to fix the build pipeline? It should be ready to go after this

I'm not a developer and I don't know exactly the steps to get that

Please, could you help me? I followed the next steps:

Output: Pages directory cannot be found at /tmp/thunderhub/pages or /tmp/thunderhub/src/pages. If using a custom path, please configure with the `no-html-link-for-pages` rule in your eslint config file.

imagen

I don't know if this is the expected output and how to continue. Could you explain more?

apotdevin commented 1 year ago

Hey @twofaktor ! No worries, I'll merge this in and run linting after