search

apotonick / gemgem-trbrb

The Trailblazer book's example app.
http://trailblazer.to#book
137 stars 60 forks source link

Chapter 03 - Fix 'label: false' #19

Closed abinoam closed 8 years ago

abinoam commented 8 years ago

Hi @apotonick,

I have updated the Simple Form Foundation templates and trimmed the repetitive 'label: false' from some views. I have also used locale files to define placeholders.

After I have began to work on this I could notice that @smathy have already worked on it on PR #9. But unfortunately his branch is stale and with conflicts.

I have also walked through each chapter from 3 to 11 merging the changes from the previous chapter and fixing anything new that appears on each chapter.

I have fixed the "no labels" issue on chapter-10 as your comment at https://github.com/apotonick/gemgem-trbrb/pull/9#issuecomment-133798856

I'm opening this PR for chapter-03 branch. But I don't know if you want me to open a PR for each chapter branch or you're gonna just fetch my repo and merge locally.

Each branch comes from its corresponding chapter branch and can be merged without conflicts.

All branches ends with feat-fix-form See: https://github.com/abinoam/gemgem-trbrb/branches/active

apotonick commented 8 years ago

Hey, thanks @abinoam :heart: I decided that I don't want to promote SimpleForm anymore and in the next book we will use Formular.

abinoam commented 8 years ago

No problem! 👍

Still slowly re-reading Trailblazer book. More to come!

Em Qua, 15 de jun de 2016 06:26, Nick Sutterer notifications@github.com escreveu:

Closed #19 https://github.com/apotonick/gemgem-trbrb/pull/19.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/apotonick/gemgem-trbrb/pull/19#event-692981437, or mute the thread https://github.com/notifications/unsubscribe/AAhrbpx8gtlCxtsxZjb4H1jgLGMoZgH-ks5qL8VYgaJpZM4IyNZk .