search

apotonick / kaminari-cells

Kaminari pagination in Cells.
MIT License
23 stars 15 forks source link

Change included Kaminari helper module for Kaminari 1.0.0 compatibility #7

Closed tjjjwxzq closed 7 years ago

tjjjwxzq commented 7 years ago

Fix breakage due to changes in file structure in Kaminari 1.0.0 by including the appropriate helper module.

tjjjwxzq commented 7 years ago

hmmm rack and activesupport require ruby >= 2.2.2?

tjjjwxzq commented 7 years ago

sorry @apotonick, this is actually my first ever open source PR (and I'm a relative newb to programming in general), so I'm not quite sure how I should be going about it :sweat_smile:

apotonick commented 7 years ago

Hey, all good and great commit, it's just that Kaminari is on a very low level of my priorities ATM. :wink:

SweeD commented 7 years ago

@apotonick Is there anything we could do to get this into master, soon? Would be awesome to be able to use kaminari in cells. 😊

apotonick commented 7 years ago

Für Säufer tu ich fast alles!

@georgemillo ??? :stuck_out_tongue_winking_eye:

george-carlin commented 7 years ago

Okay, I just released kaminari-cells 1.0.0, which is compatible (or at least it should be!) with kaminari 1+. For Kaminari <1, use kaminari-cells 0.1.0 (which I also just released.)

george-carlin commented 7 years ago

PS thanks @tjjjwxzq for fixing this! Sorry for the delay.

tjjjwxzq commented 7 years ago

@georgemillo ah awesome!

apotonick commented 7 years ago

this is actually my first ever open source PR

@tjjjwxzq It might be your first PR ever but your presentation at RedDot didn't look like it's your first talk. Amazing job! :sparkles: I learned a lot about meta-meta-meta classes (and I had a feeling I never really understood the meta-meta layer)... :rofl:

tjjjwxzq commented 7 years ago

Thank you @apotonick! :smile_cat: Thanks for Trailblazer too and a chance for me to do my first OSS contrib :joy: (I'm afraid meta-meta-meta classes don't help much here...)

apotonick commented 7 years ago

Well, let's put it that way, it's good to know meta-classes but I honestly had no idea that for every class a meta class (or meta-meta-meta-meta) is generated! :female_detective: