app-dirs-rs / app_dirs2

A maintained fork of the app-dirs-rs project.
MIT License
35 stars 7 forks source link

Add CI through GitHub actions #29

Closed MarijnS95 closed 2 years ago

MarijnS95 commented 2 years ago

An often-used crate like app_dirs2 can't really go without automated code checking and tests: as bare minimum the code should be formatted correctly and satisfy standard clippy lints to the delight of developers and contributors, and the tests should be executed to make sure the result keeps working at all times. Finally the documentation is build-tested to make sure that it contains no invalid links nor broken markdown.

This script is copied verbatim from my contribution at https://github.com/dvc94ch/cargo-subcommand/commit/0a53c8994af15a07283f5868127cb8fb1128d611, only ubuntu and macos are added to the test runs.


This PR obviously implies that all these issues are fixed, for which I opened separate PRs. Please merge those first, then I'll rebase the commits out of this one :)

MarijnS95 commented 2 years ago

@kornelski With all that, CI now succeeds :grin: https://github.com/MarijnS95/app_dirs2/actions/runs/2420826128

kornelski commented 2 years ago

Great. Thanks!