android: Upgrade to `jni 0.21`

[MarijnS95]

Cc @rib

[rib]

yeah, those changes look good to me.

the clippy issues look completely unrelated to this, so seems fine to ignore those here.

[MarijnS95]

The clippy issues look completely unrelated to this, so seems fine to ignore those here.

New Rust version, stricter (really: more complete/correct/accurate) clippy lints, for better or for worse :)

[kornelski]

Thank you

[MarijnS95]

Thank you @kornelski for the quick release!

Fwiw I see additional clippy changes, are you running a configuration locally that differs from the CI?

[kornelski]

I just run clippy manually and selectively apply what seems sensible

[MarijnS95]

Would be great to list those in the CI and/or lib.rs so that contributors can proactively address them too.

[kornelski]

I'd rather not add stronger clippy requirements in the CI, because these are suggestions, not absolute requirements. If the clippy build in CI is confusing or getting in the way of PRs, I'd rather remove it from CI.

[MarijnS95]

Just asking how/where you'd manage to find more: manually requesting them on the command line or running a newer-than-stable toolchain?

[kornelski]

I've added -W clippy::pedantic to the flags.