app-generator / free-site-builder

Free Site Builder - Open-Source Tool | Simpllo
https://www.simpllo.com
Other
295 stars 61 forks source link

[👉UNASSIGNED] Netlify Popup - Help not working #73

Closed app-generator closed 1 year ago

app-generator commented 1 year ago

STATUS: ASSIGNED to @umarali

Context

The Deployment popup should provide minimal help to the user.

NOTE: This is a regression caused by the migration of the tool to NPM/CDN support

@umarali please take a look.

TY!

image

umarali commented 1 year ago

Noted!

umarali commented 1 year ago

@app-generator the DNDBuilder error occurs before the popover toggle method is called, hence causing the popover to not toggle.

Screen Shot 2023-07-29 at 7 43 46 PM
app-generator commented 1 year ago

Yep, the type is not defined in that scope. Moreover, we have this Constructor in the index.ts:

new DNDBuilder(
  {
    dropContainer: "dropzone",
    dropIndicator: "drop-here-indicator",
  },
  {
    actionPreview: "#action_preview",
    actionDownload: "#action_download",
    actionDeploy: "#action_deploy",
    closeModal: "#closeModal",
    fullScreenOption: "#fullScreenOption",
    tabletOption: "#tabletOption",
    mobileOption: "#mobileOption",
    deployForm: "#deployForm",
  }
);

In fact, the C-tor should be exposed by the library and called in the PAGE (script tag).

app-generator commented 1 year ago

@yurec133 The current implementation might require some fixes. Please take a look.

yurec133 commented 1 year ago

var builder = new DNDBuilder({ dropContainer: 'dropzone', dropIndicator: 'drop-here-indicator' }); do not need to be used in index.html new DNDBuilder remove it from index.html

new DNDBuilder should be used only when using npm package

umarali commented 1 year ago

@yurec133 please take a look at the updated implementation and share your feedback. Thanks! Closing this one.