search

app-json / app-json-fetcher

A CORS-friendly webservice for fetching app.json file content from GitHub and Bitbucket repos
http://app-json-fetcher.herokuapp.com/?repository=bitbucket:sikelianos/web-starter-kit
1 stars 3 forks source link

Problem if GitHub default branch is configured to be something other than master #2

Open friism opened 9 years ago

friism commented 9 years ago

I skimmed the app.json resolution and couldn't find the problem, but there's definitely an issue. Example here: https://github.com/friism/trypurescript

Best solution so far is probably to tell people hosting buttons to use master as the default branch.

mietek commented 9 years ago

Thanks for picking up the issue.

zeke commented 9 years ago

Hi @friism!

How does it break? I can help fix this if you provide more detail about the problem.

This might be solved by updating the github-url-to-object dependency. When I enter the https://github.com/friism/trypurescript/tree/haskell-on-heroku URL on this page, it appears to parse the branch properly: https://github-url-to-object.herokuapp.com/

friism commented 9 years ago

@zeke it breaks because master is not the default branch and master branch doesn't contain app.json. Try clicking the button here: https://github.com/friism/trypurescript

The problem is likely that the assumption that a user coming from the URL https://github.com/friism/trypurescript means that we want to do something with the master branch is not correct.

Default branch can be configured in GitHub repo settings.