app-json / app.json

A node module for working with app.json files and deploying app.json apps to Heroku. Designed to work on the server, the browser, and the command line.
132 stars 26 forks source link

app.json validate reports an error about a valid formation key #26

Open jacobian opened 8 years ago

jacobian commented 8 years ago

Using this app.json, app.json validate reports an error:

$ app.json validate

Found an app.json file, but it's got some issues:

- formation must be of array type

The relevant formation is:

    "formation": {
        "web": {
            "quantity": 1,
          " size": "Free"
        },
        "worker": {
            "quantity": 1,
            "size": "Free"
        }
    }

Despite the error, this appears to be correct -- that is, using the Heroku Button on that repo correctly deploys an app with web and worker dynos correctly set to 1 free each.

fjsj commented 8 years ago

+1

benjaminbradley commented 8 years ago

The example in schema.js shows the expected format: "example": [ { "process": "web", "quantity": 1, "size": "standard-2X" }, { "process": "worker", "quantity": 1, "size": "standard-2X" } ] https://github.com/app-json/app.json/blob/master/lib/schema.js#L81

pdfrod commented 8 years ago

The documentation on Heroku suggests a different format:

{
  "formation": {
    "web": {
      "quantity": 2,
      "size": "Performance-M"
    }
  }
}

https://devcenter.heroku.com/articles/app-json-schema#formation

austinmcconnell commented 6 years ago

I can confirm this issue/error is still occuring.

farmisen commented 2 years ago

as far as I can tell this is still occurring