app-registry / appr-helm-plugin

Apache License 2.0
56 stars 15 forks source link

Doesn't implement all semver #11

Closed charltonaustin closed 7 years ago

charltonaustin commented 7 years ago

When I run the following I get that output.

$ helm registry delete-package  registry-name/namespace/name@0.2.0-staging+ee418a3b-2656-428e-9c3c-2322af21f60d

usage: cnr delete-package [-h] [--output {text,none,json,yaml}]
                          [-H REGISTRY_HOST] -t MEDIA_TYPE [-v VERSION]
                          package
cnr delete-package: error: Package 'registry-name/namespace/name@0.2.0-staging+ee418a3b-2656-428e-9c3c-2322af21f60d' does not match format '[registry/]namespace/name[@version|:channel]'

However when I run.

$ helm registry delete-package  registry-name/namespace/name@0.2.0-staging
usage: cnr [-h]
           {show,inspect,logout,plugins,helm,pull,list,delete-package,version,push,login,config,channel}
           ...
cnr: error: 404 Client Error: NOT FOUND for url: https://quay.io/cnr/api/v1/packages/registry-name/namespace/name/0.2.0-staging/helm
Error: plugin "registry" exited with error

The +<uuid> is how we identify which build the deploy comes from.

ant31 commented 7 years ago

Thanks to report this error. There is a typo in the regexp, it doesn't include the '+' char(https://github.com/app-registry/appr-cli/blob/master/cnrclient/utils.py#L6) I'll push a new release shortly.

ant31 commented 7 years ago

released:
https://github.com/app-registry/helm-plugin/releases/tag/v0.3.8

gtaylor commented 7 years ago

@ant31 does that mean this is safe to close?