search

appKODE / detekt-rules-compose

A collection of Detekt rules for Jetpack Compose
MIT License
136 stars 8 forks source link

Improve ReusedModifierInstance #24

Closed dimsuz closed 1 year ago

dimsuz commented 1 year ago

This rule now uses type resolution to be smarter and is now able to correctly detekt when a composable call does not have a modifier parameter at all, and will not report usage of modifier in composable children of this call as an error.

Fixes https://github.com/appKODE/detekt-rules-compose/issues/5

dimsuz commented 1 year ago

Great, thanks! I was going to ask for review :)

I plan to start improving other rules with type resolution too. Almost all currently open issues require deeper insights into types to be properly fixed.

BraisGabin commented 1 year ago

Feel free to add me as reviewer if you want for any other pr 👍🏻