search

appajid / Ambarisha

A Unicode Kannada Font with condensed look
SIL Open Font License 1.1
4 stars 3 forks source link

Vertical metrics #5

Closed davelab6 closed 8 years ago

davelab6 commented 8 years ago

The vertical metrics are not quite right:

$ fontbakery-fix-vertical-metrics.py fonts/Ambarisha-Regular.ttf 
Parameter              Ambarisha-Regular.ttf    
ymax                   878                      
hhea.ascent            750                      
OS/2.sTypoAscender     750                      
OS/2.usWinAscent       850                      
ymin                   -698                     
hhea.descent           -250                     
OS/2.sTypoDescender    -250                     
OS/2.usWinDescent      350                      
hhea.lineGap           200                      
OS/2.sTypoLineGap      200                      
hhea total             1200                     
typo total             1200                     
win total              1200                     
UPM:Heights            1000:1576                
UPM:Heights %          157 %                    

High Glyphs
Ambarisha-Regular.ttf: knNNI knLLLI knRRI

Low Glyphs
Ambarisha-Regular.ttf: uni013C uni013B zerowidthjoiner knTAc2.following knsignvR knsignvL knNGAc2.following knsignvR.following knNYAc2 knCHAc2 knJHAc2.following knLLAc2 knCAc2.following knVAc2 knCHAc2.following knDDHAc2 knsignvLL knSHAc2 knSAc2.following knTTHAc2 uni0156 knAIlengthmark.following knSSAc2.following knLLLAc2 knDHAc2 knTAc2_RAc2.following knDDAc2 knTHAc2 knLAc2 knKHAc2 knGHAc2 knGAc2 commaaccentcmb knNYAc2.following knDDAc2.following knRRAc2 knGAc2.following uni0122 knGHAc2.following commaaccent knDAc2 knPHAc2.following knRAc2.following knDAc2.following knNNAc2 knVAc2.following knNAc2 knTAc2 uni0162 uni0163 knLLAc2.following knHAc2.following knJHAc2 knsignvRR knCAc2 knKSSAc2.following knNAc2.following knKSSAc2 knsignvRR.following uni015F uni015E knTTHAc2.following knSSAc2.kssa knNNAc2.following uni0157 knHAc2 knDHAc2.following knRRAc2.following knKAc2.following knYAc2 knSSAc2 knJAc2.following knTTAc2 knDDHAc2.following knPAc2 knBHAc2.following knBHAc2 knKAc2 knLLLAc2.following knJAc2 knLAc2.following knTHAc2.following knPAc2.following knTAc2_RAc2 knBAc2.following knPHAc2 knSAc2 knAIlengthmark knMAc2.following knBAc2 knMAc2 knKHAc2.following knsignAI zerowidthnonjoiner knYAc2.following knSHAc2.following knNGAc2 knTTAc2.following
$

They should be

$ fontbakery-fix-vertical-metrics.py --autofix fonts/Ambarisha-Regular.ttf ;
$ fontbakery-fix-vertical-metrics.py fonts/Ambarisha-Regular.ttf.fix ;
Parameter              Ambarisha-Regular.ttf.fix    
ymax                   878                          
hhea.ascent            878                          
OS/2.sTypoAscender     878                          
OS/2.usWinAscent       878                          
ymin                   -698                         
hhea.descent           -698                         
OS/2.sTypoDescender    -698                         
OS/2.usWinDescent      698                          
hhea.lineGap           0                            
OS/2.sTypoLineGap      0                            
hhea total             1576                         
typo total             1576                         
win total              1576                         
UPM:Heights            1000:1576                    
UPM:Heights %          157 %

I will make a pull request to address this.

appajid commented 8 years ago

You mean Totals should be 1576? hhea total 1576
typo total 1576
win total 1576

davelab6 commented 8 years ago

Yes.

davelab6 commented 8 years ago

Fixed in https://github.com/appajid/Ambarisha/commit/e85a79036d1c968ec8dedafcb85a90acfb6fda8f