appalachianstate / moodle-filter_rtmp

RTMP streaming media filter plugin
0 stars 2 forks source link

modify for Cloudfront private signed streaming URL #1

Closed tazus closed 11 years ago

tazus commented 11 years ago

The code can't support using Cloudfront's private signed url which have more paramenters behind the file name, expample are: href="rtmp://films-XXXXX.com/cfx/st/mp4:00-00.mp4?Policy=eyJTdGF0ZW1lbnQiOlt7IkNvbmRpdGlvbiI6eyJJcEFkZHJlc3MiOnsiQVdTOlNvdXJjZUlwIjoiMTQwLjEzMC4xMDguMjAifSwiRGF0ZUxlc3NUaGFuIjp7IkFXUzpFcG9jaFRpbWUiOjEzNjQ2NTA1MzB9fX1dfQo&Signature=lMeezlyL8VCSaoPz42r8NRXRcw73NZ1sxou4ukXfnf3AnUKQlLXBmbU5~FsWAsnIDpZtRSggMv0Ct129upuNiBDrS4yn03HjbVCX-x8x0gSN8Iz5Dzq0-rtlvAyP0FM43UovTuQp3fiOkf0HwjQ-dYDTP22gy8rakCypTkXpWYk&Key-Pair-Id=APKAICTJECYI2XXXXXXX"

this create two kind of problems:

  1. the position of query parameters should be after file name meida-path (URL in flowplayer), current code put it after media-conx
  2. anohter one is the "&", "=" and "?" inside URL, when Cloudfront created URL, it uses %26, %3D, and %3F current code has problem parse it.

I tried to modified the code but can't get it work.

woolardfa commented 11 years ago

Have created CONTRIB-4230 (https://tracker.moodle.org/browse/CONTRIB-4230).

woolardfa commented 11 years ago

I have corrected the way streaming URLs with query string parameters are constructed. I do not have a Cloudfront account with which to test the change. Would you please test the change and advise if it works or not?

You can find the corrected version of the renderer.php file in the github repository here: https://github.com/appalachianstate/moodle-filter_rtmp/tree/CONTRIB-4230

The only file changed is renderer.php

Regards,FW