appany / AppAny.Quartz.EntityFrameworkCore.Migrations

EntityFrameworkCore PostgreSQL migrations for Quartz.NET
MIT License
70 stars 18 forks source link

Adding mysql implementation, fixing namespaces for shared project #46

Closed marblekirby closed 1 year ago

marblekirby commented 1 year ago

Changes

marblekirby commented 1 year ago

Hi Sergey, I've updated the namespaces, and introduced some tests for MySQL following the same testing patterns you have in place for Postgres

sergeyshaykhullin commented 1 year ago

Thank you for this PR!

You need two more things to complete:

marblekirby commented 1 year ago

Updated both release + tests. Tests for MySQL are passing

codecov-commenter commented 1 year ago

Codecov Report

Base: 84.55% // Head: 91.27% // Increases project coverage by +6.72% :tada:

Coverage data is based on head (953b340) compared to base (19f1de5). Patch coverage: 98.93% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #46 +/- ## ========================================== + Coverage 84.55% 91.27% +6.72% ========================================== Files 28 40 +12 Lines 602 1066 +464 Branches 2 2 ========================================== + Hits 509 973 +464 Misses 92 92 Partials 1 1 ``` | [Impacted Files](https://codecov.io/gh/appany/AppAny.Quartz.EntityFrameworkCore.Migrations/pull/46?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=appany) | Coverage Δ | | |---|---|---| | [...kCore.Migrations/EntityTypeConfigurationContext.cs](https://codecov.io/gh/appany/AppAny.Quartz.EntityFrameworkCore.Migrations/pull/46/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=appany#diff-c3JjL0FwcEFueS5RdWFydHouRW50aXR5RnJhbWV3b3JrQ29yZS5NaWdyYXRpb25zL0VudGl0eVR5cGVDb25maWd1cmF0aW9uQ29udGV4dC5jcw==) | `100.00% <ø> (ø)` | | | [...FrameworkCore.Migrations/ModelBuilderExtensions.cs](https://codecov.io/gh/appany/AppAny.Quartz.EntityFrameworkCore.Migrations/pull/46/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=appany#diff-c3JjL0FwcEFueS5RdWFydHouRW50aXR5RnJhbWV3b3JrQ29yZS5NaWdyYXRpb25zL01vZGVsQnVpbGRlckV4dGVuc2lvbnMuY3M=) | `70.00% <ø> (ø)` | | | [...ameworkCore.Migrations/Quartz/QuartzBlobTrigger.cs](https://codecov.io/gh/appany/AppAny.Quartz.EntityFrameworkCore.Migrations/pull/46/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=appany#diff-c3JjL0FwcEFueS5RdWFydHouRW50aXR5RnJhbWV3b3JrQ29yZS5NaWdyYXRpb25zL1F1YXJ0ei9RdWFydHpCbG9iVHJpZ2dlci5jcw==) | `0.00% <0.00%> (ø)` | | | [...yFrameworkCore.Migrations/Quartz/QuartzCalendar.cs](https://codecov.io/gh/appany/AppAny.Quartz.EntityFrameworkCore.Migrations/pull/46/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=appany#diff-c3JjL0FwcEFueS5RdWFydHouRW50aXR5RnJhbWV3b3JrQ29yZS5NaWdyYXRpb25zL1F1YXJ0ei9RdWFydHpDYWxlbmRhci5jcw==) | `0.00% <ø> (ø)` | | | [...ameworkCore.Migrations/Quartz/QuartzCronTrigger.cs](https://codecov.io/gh/appany/AppAny.Quartz.EntityFrameworkCore.Migrations/pull/46/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=appany#diff-c3JjL0FwcEFueS5RdWFydHouRW50aXR5RnJhbWV3b3JrQ29yZS5NaWdyYXRpb25zL1F1YXJ0ei9RdWFydHpDcm9uVHJpZ2dlci5jcw==) | `0.00% <ø> (ø)` | | | [...meworkCore.Migrations/Quartz/QuartzFiredTrigger.cs](https://codecov.io/gh/appany/AppAny.Quartz.EntityFrameworkCore.Migrations/pull/46/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=appany#diff-c3JjL0FwcEFueS5RdWFydHouRW50aXR5RnJhbWV3b3JrQ29yZS5NaWdyYXRpb25zL1F1YXJ0ei9RdWFydHpGaXJlZFRyaWdnZXIuY3M=) | `0.00% <ø> (ø)` | | | [...FrameworkCore.Migrations/Quartz/QuartzJobDetail.cs](https://codecov.io/gh/appany/AppAny.Quartz.EntityFrameworkCore.Migrations/pull/46/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=appany#diff-c3JjL0FwcEFueS5RdWFydHouRW50aXR5RnJhbWV3b3JrQ29yZS5NaWdyYXRpb25zL1F1YXJ0ei9RdWFydHpKb2JEZXRhaWwuY3M=) | `0.00% <ø> (ø)` | | | [...ntityFrameworkCore.Migrations/Quartz/QuartzLock.cs](https://codecov.io/gh/appany/AppAny.Quartz.EntityFrameworkCore.Migrations/pull/46/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=appany#diff-c3JjL0FwcEFueS5RdWFydHouRW50aXR5RnJhbWV3b3JrQ29yZS5NaWdyYXRpb25zL1F1YXJ0ei9RdWFydHpMb2NrLmNz) | `0.00% <ø> (ø)` | | | [...Core.Migrations/Quartz/QuartzPausedTriggerGroup.cs](https://codecov.io/gh/appany/AppAny.Quartz.EntityFrameworkCore.Migrations/pull/46/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=appany#diff-c3JjL0FwcEFueS5RdWFydHouRW50aXR5RnJhbWV3b3JrQ29yZS5NaWdyYXRpb25zL1F1YXJ0ei9RdWFydHpQYXVzZWRUcmlnZ2VyR3JvdXAuY3M=) | `0.00% <ø> (ø)` | | | [...workCore.Migrations/Quartz/QuartzSchedulerState.cs](https://codecov.io/gh/appany/AppAny.Quartz.EntityFrameworkCore.Migrations/pull/46/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=appany#diff-c3JjL0FwcEFueS5RdWFydHouRW50aXR5RnJhbWV3b3JrQ29yZS5NaWdyYXRpb25zL1F1YXJ0ei9RdWFydHpTY2hlZHVsZXJTdGF0ZS5jcw==) | `0.00% <ø> (ø)` | | | ... and [18 more](https://codecov.io/gh/appany/AppAny.Quartz.EntityFrameworkCore.Migrations/pull/46/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=appany) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=appany). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=appany)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.