Closed JasonLandbridge closed 9 months ago
Hi,
Thanks for the insights!
I think my #50 should wait for #49 and then I can create a seperate PR for the agreed proposals?
Another improvement can be to use https://github.com/Deffiss/testenvironment-docker or similar for integration tests and use non standard ports to avoid collisions on dev machines
Another improvement can be to use https://github.com/Deffiss/testenvironment-docker or similar for integration tests and use non standard ports to avoid collisions on dev machines
Yes, but testenvironment has no mysql support right now
@JasonLandbridge Does all suggestions completed in https://github.com/appany/AppAny.Quartz.EntityFrameworkCore.Migrations/pull/50?
Only 4 and 5 are left
Clean-up the AppAny.Quartz.EntityFrameworkCore.Migrations.Tests project where each database type gets its own folder.
I added a integration test that creates a Quartz scheduler with the dbcontext provided as a jobstore SQLiteIntegrationDbContext_IntegrationTests.cs. Maybe do this for the other Database types as well?
4 needs a bit more love and 5 requires setting up some docker containers to do some actual real database testing. Maybe someone can else pick that up?
This might be a good starting point: https://dotnet.testcontainers.org/ (video about it)
Another improvement can be to use https://github.com/Deffiss/testenvironment-docker or similar for integration tests and use non standard ports to avoid collisions on dev machines
Yes, but testenvironment has no mysql support right now
It's actually support MariaDB which is technically MySQL as OSS. I've checked source code and it's using MySqlConnector for db access
I've created new PR #56 to improve Integration tests using https://github.com/Deffiss/testenvironment-docker
I've created new PR #56 to improve Integration tests using https://github.com/Deffiss/testenvironment-docker
@ZaoralJ Thank you for your contribution!
Merged
Seems like there are no more actionable tasks
If i missed something please open new granular issues with project improvements
Hi there,
While making my #50 PR, I thought of some improvements that might be interesting:
prefix
andschema
parameters with default values forUseSqlite()
,UseMySQL()
etcBecause then the setup becomes even easier and cleaner
EntityConfigurations
And then the configuration for every database type becomes:
AppAny.Quartz.EntityFrameworkCore.Migrations.Tests
project where each database type gets its own folder.I added a integration test that creates a Quartz scheduler with the dbcontext provided as a jobstore SQLiteIntegrationDbContext_IntegrationTests.cs. Maybe do this for the other Database types as well?
@sergeyshaykhullin and @ZaoralJ, What do you guys think?