appany / helm-oci-chart-releaser

Push Helm Charts to OCI-based registries
MIT License
60 stars 15 forks source link

Failure when special characters are present in password #14

Closed feynmanliang closed 4 weeks ago

feynmanliang commented 8 months ago

Describe the bug

When the OCI password contains a ")", this action fails with "bash: syntax error near unexpected token `)'".

Root cause is https://github.com/appany/helm-oci-chart-releaser/blob/main/action.yaml#L45 does not escape its input.

Current workaround is to escape manually in the yaml

registry_password: "\"mypass)\""

Would be nice if escaping was handled in the action instead.

sergeyshaykhullin commented 7 months ago

@feynmanliang PRs are welcome!