search

apparatus / fuge-runner

Process and container runner and watcher for the fuge tool
MIT License
4 stars 19 forks source link

Clean processes #38

Closed pelger closed 7 years ago

pelger commented 7 years ago

factored out into windows, and *nix runners, removed profiling code into profileRunner for the attention of @davidmarkclements

pelger commented 7 years ago

if you look in process runner you will see that it handles node as a container type and pulls the node path from the fuge executable...

mcollina commented 7 years ago

@pelger can you paste in a link? I don't see it.

I see https://github.com/apparatus/fuge-runner/pull/38/files#diff-a2ac54e027efc9536019e857fd7ec2a1L43 is removed. It's needed for windows to get the node path on windows.

pelger commented 7 years ago

It's here: https://github.com/apparatus/fuge-runner/blob/clean_processes/lib/processRunner.js#L36-L48

pelger commented 7 years ago

Also windows is now refactored into it's own runner see windowsRunner.js

mcollina commented 7 years ago

Sorry my bad :).