search

apparentlymart / python-stl

Python library for parsing and producing STL files, in both ASCII and binary formats. No longer maintained.
MIT License
9 stars 13 forks source link

Added support for Python3 #9

Open Gjacquenot opened 8 years ago

Gjacquenot commented 8 years ago

These commits only modify the StringIO import

Gjacquenot commented 8 years ago

@apparentlymart : Could you have a look at this PR? This PR allows to run code with Python 3!

apparentlymart commented 8 years ago

@Gjacquenot, thanks for this, and sorry for the lack of response!

It seems like this PR has some other changes beyond Python 3 compatibility, so it's hard for me to find and review the parts that are relevant here and so I'd planned to come back and figure that out but I'd not yet had the time to do so.

If you wouldn't mind rebase this changeset so that only includes the Python3 compatibility changes then I can probably review it faster. No pressure to do that, though; if you don't have time then I'll take care of it when I do. :grinning:

Gjacquenot commented 8 years ago

Well, I have created this PR quite a long time ago, and @eyal0 proposed me to add a new method. I have accepted it, and it is now in my original PR. I will try to split the two.

Till commit everything should be about moving code to Python3

Gjacquenot commented 7 years ago

@apparentlymart Do you think you will have time to review this PR?