Handle directory of . / extra log messages

apparentlymart / terraform-clean-syntax

A simple tool for Terraform language syntax cleanup, extending terraform fmt

Mozilla Public License 2.0

160 stars 24 forks source link

Handle directory of . / extra log messages #3

Closed bwalding closed 4 years ago

bwalding commented 4 years ago

Added the ability to handle multiple command line arguments
It wasn't obvious why terraform-clean-syntax . didn't work (it's because you look for a directory prefix of . and skip it). So I made that work.
I also logged when files weren't updated - might be a bit noisy - I added it while trying to workout why cleaning . didn't work.

Feel free to adjust / drop this PR!

apparentlymart commented 4 years ago

Thanks for working on this, @bwalding!

I have pushed a slightly modified version of this to master as 6e95838341349e7ae4fe5df42a1985f6a97ce312; I took a slightly different strategy to making . work so that .. could also potentially work, and I also skipped printing out when a file has no changes because indeed it seemed pretty noisy on some larger configurations I tried it on and I worry it would make it harder to pick out the other log messages when scanning over the logs.

bwalding commented 4 years ago

Thanks for merging - no issues with modifying my PR :)

Some of the changes were really only caused by my journey of discovery trying to get my TF repo cleaned up.