search

appbaseio / appbase-js

appbase.io search client library for JavaScript
MIT License
42 stars 18 forks source link

v1.0.0 on npm package #16

Closed maruilian11 closed 6 years ago

maruilian11 commented 8 years ago

hi, we want to host your lib on https://cdnjs.com, I saw v1.0.0 on npm package, it looks strange because the latest version is v0.10.8, and there is no v1.0.0 on github. I want to confirm do we also need to put v1.0.0 on cdnjs?
thank you very much!

https://github.com/cdnjs/cdnjs/pull/8914

girishramnani commented 8 years ago

the one which connects to this repository is https://www.npmjs.com/package/appbase-js. which is of version v0.10.8 and hence in sync.

siddharthlatest commented 8 years ago

@maruilian11 v1.0.0 can be safely ignored. Thanks!

PeterDaveHello commented 8 years ago

@siddharthlatest won't there be a new 1.0.0 in the future?

siddharthlatest commented 8 years ago

I am working with npmjs support for unpublishing the 1.0.0 version. If that goes well, we will publish a new 1.0.0 version in the future.

-Siddharth

On Fri, Sep 9, 2016 at 5:15 AM, Peter Dave Hello notifications@github.com wrote:

@siddharthlatest https://github.com/siddharthlatest won't there be a new 1.0.0 in the future?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/appbaseio/appbase-js/issues/16#issuecomment-245875338, or mute the thread https://github.com/notifications/unsubscribe-auth/AAmdGs9trhoGCYUZdKt5QxWgfRSem5q3ks5qoTHLgaJpZM4J39iC .

siddharthlatest commented 8 years ago

@PeterDaveHello I am not sure how you include / ignore versions, would a ignored version be added to a .gitignore file? If we ignore 1.0.0 version now, I am happy to submit an issue at a later date when we hit the 1.0.0 milestone.

PeterDaveHello commented 8 years ago

@siddharthlatest you are correct, using the .gitignore to exlucde the versions been fetched from the auto-updater, thanks for your help, I think we can just add this library with the .gitignore mask.

siddharthlatest commented 6 years ago

Closing this issue, as we are already past v2.