Closed siddharthlatest closed 7 years ago
We would like to add support for nested queries within mirage, and along with it also support nested object field selection in the fields drop down.
Original request in https://github.com/appbaseio/mirage/issues/20.
Prerequisites
You can try out the live version of mirage here - https://appbaseio.github.io/mirage.
You will need to know how Elasticsearch works, reference can be found here.
Build mirage locally and understand the code structure. This doc attempts to explain that - https://github.com/appbaseio/mirage/blob/dev/HOW-TO-CONTRIBUTE.md.
Code Structure
The code structure will resemble the files in this path - https://github.com/appbaseio/mirage/tree/dev/app/build/singlequery/queries.
There should be two files created: nested.query.ts and nested.query.spec.ts.
Before PR
Ensure the logic is impeccable, a test spec is written, no unused variables are present and indentation matches with the rest of the codebase.
See example PR https://github.com/appbaseio/mirage/pull/22
Added in 661262575ec326c940e603c1664dc9b3c504d254 and released with v0.4.0.
v0.4.0
We would like to add support for nested queries within mirage, and along with it also support nested object field selection in the fields drop down.
Original request in https://github.com/appbaseio/mirage/issues/20.
Prerequisites
You can try out the live version of mirage here - https://appbaseio.github.io/mirage.
You will need to know how Elasticsearch works, reference can be found here.
Build mirage locally and understand the code structure. This doc attempts to explain that - https://github.com/appbaseio/mirage/blob/dev/HOW-TO-CONTRIBUTE.md.
Code Structure
The code structure will resemble the files in this path - https://github.com/appbaseio/mirage/tree/dev/app/build/singlequery/queries.
There should be two files created: nested.query.ts and nested.query.spec.ts.
Before PR
Ensure the logic is impeccable, a test spec is written, no unused variables are present and indentation matches with the rest of the codebase.