search

appbaseio / mirage

:art: GUI for simplifying Elasticsearch Query DSL
http://opensource.appbase.io/mirage
Other
2.21k stars 123 forks source link

Custom Dejavu URL #56

Open geraldclark opened 6 years ago

geraldclark commented 6 years ago

Is there a recommended approach for updating the dejuvu "Data View" url to a local docker instance of dejavu?

siddharthlatest commented 6 years ago

@geraldclark You should be able to change this in the source, and then build a custom docker image to do this.

The specific place you would need to change this is here - https://github.com/appbaseio/mirage/blob/901354fa335dded9798d78ce62088d742c45e587/app/app.component.ts#L646.

I am not sure if it make sense for us to add this in the code as it may hurt accessibility in case a user doesn't have the other plugin installed locally.

geraldclark commented 6 years ago

@siddharthlatest I was just thinking it might be beneficial to allow for an external configuration as I'd prefer to not have to build a custom docker image or modify the core app source.

siddharthlatest commented 6 years ago

That's a good idea. We would probably want to support some level of configurability (via env variables), but I am not sure atm what other things may be useful to go in. That said, I am happy to accept a PR for this specific configuration to get us started on that path.