appbaseio / reactivebase

Data components for building reactive UIs
Apache License 2.0
18 stars 2 forks source link

Dynamically update highlight in DataSearch #198

Closed divyanshu013 closed 6 years ago

siddharthlatest commented 6 years ago

@divyanshu013 What is the issue about?

divyanshu013 commented 6 years ago

This happens when we toggle highlight prop. Currently when the query remains the same the highlight prop isn't updated probably due to channel manager. So after toggling highlight prop we have to type in some other query to see the highlight getting reflected. For example on the playground example this can be seen.

@metagrover can explain better about the channel manager logic

divyanshu013 commented 6 years ago

Fixed in reactivesearch v2, related https://github.com/appbaseio/reactivesearch/issues/81