search

appbaseio / reactivesearch

Search UI components for React and Vue
https://opensource.appbase.io/reactivesearch
Apache License 2.0
4.89k stars 466 forks source link

ReactiveComponent not clearing the url param when removing Selected Filter #1460

Closed DustinKLo closed 3 years ago

DustinKLo commented 4 years ago

Affected Projects React

Library Version: x.y.z 3.8.5

Describe the bug When the facet is cleared, the url param of the component isnt removed, however clicking clear all removes it

To Reproduce https://codesandbox.io/s/reactivecomponent-7mpr5?file=/src/index.js

Expected behavior the url param should be removed when clearing

Screenshots

Desktop (please complete the following information):

working code sandbox: https://codesandbox.io/s/reactivecomponent-7mpr5?file=/src/index.js

bietkul commented 4 years ago

@jyash97 Can you check on this?

jyash97 commented 4 years ago

Hey @DustinKLo

Thanks for reporting the issue. I can see the value is reset but the URLParams are not removed. I will check on this today and will create a fix for this.

bietkul commented 4 years ago

@jyash97 Any update on this?

sa-aj commented 3 years ago

I am also facing this issue can you please help @bietkul did you find any solution ?

DustinKLo commented 3 years ago

@sa-aj i resorted to using the latest version of the library which didn't have this bug

"@appbaseio/reactivesearch": "3.2.4",

its not a true fix but hopefully this helps

DustinKLo commented 3 years ago

@bietkul @jyash97 is there any update on this? If not i can give it a shot if you can point me to where to look regarding the logic that handles the URLParams value

DustinKLo commented 3 years ago

i was able to "somewhat" fix the issue, the url query param now clears when clearing the (ReactiveComponent) filter https://github.com/appbaseio/reactivesearch/compare/next...DustinKLo:fix_reactivecomponent_url

but when the page loads with the query param already set, the filter is not used ReactiveComponent also doesn't work when using page forward and backwards on the browser

can someone point me where to look to make a proper fix to this issue? thanks 👍

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

sbeus commented 2 years ago

This appears to still be an issue with no real work-around. Can it be re-opened for investigation?

paulo-h-cunha commented 2 years ago

Facing the same issue. Please re-open!