appbaseio / reactivesearch

Search UI components for React and Vue
https://opensource.appbase.io/reactivesearch
Apache License 2.0
4.9k stars 467 forks source link

ReactiveComponent re renders custom component within render props #1704

Open aoloo opened 3 years ago

aoloo commented 3 years ago

Affected Projects React

Library Version: x.y.z ^3.18.1

Describe the bug When utilizing ReactiveComponent and rendering a custom component in render prop. ReactiveComponent re renders numerous number of times causing performance issues.

To Reproduce https://codesandbox.io/s/reactive-component-re-renders-ynqth?file=/src/index.js In a small code sandbox implementation, the sandbox console outputs the re rendered value within the render props.

Within a bare bones implementation in production environment the component is rendered more than 200 times. Expected behavior The component in render props should only be rendered once than multiple times.

Screenshots image image

Desktop (please complete the following information):

Smartphone (please complete the following information): N/A

Additional context N/A

siddharthlatest commented 3 years ago

@aoloo Thanks for bringing attention to this, I'm able to reproduce it. We will be fixing this in the next release.

The same issue is replicable with:

components as well.