search

appbaseio / reactivesearch

Search UI components for React and Vue
https://opensource.appbase.io/reactivesearch
Apache License 2.0
4.9k stars 467 forks source link

renderItem MultiDataList 3rd parameter wrong #1821

Closed freddyftw closed 2 years ago

freddyftw commented 2 years ago

https://github.com/appbaseio/reactivesearch/blob/1c2f5fb313c32613501756c870accac3e54a9afe/packages/web/src/components/list/MultiDataList.js#L508

Shouldn't the 3rd argument be isChecked from https://github.com/appbaseio/reactivesearch/blob/1c2f5fb313c32613501756c870accac3e54a9afe/packages/web/src/components/list/MultiDataList.js#L479 ? I'm always getting false in isSelected

mohdashraf010897 commented 2 years ago

@freddyftw Hey 👋 , thanks for reaching out. will shortly respond with something. Meanwhile, I would recommend using the Issue Template 👉 https://github.com/appbaseio/reactivesearch/blob/next/.github/ISSUE_TEMPLATE/bug_report.md for reporting any issue.

mohdashraf010897 commented 2 years ago

@freddyftw You can upgrade to Version 3.26.1-alpha.2 that specifically fixes the above issue.

Working Demo 👉 https://codesandbox.io/embed/elastic-beaver-4jvem?fontsize=14&hidenavigation=1&theme=dark

Thanks