appbaseio / reactivesearch

Search UI components for React and Vue
https://opensource.appbase.io/reactivesearch
Apache License 2.0
4.89k stars 471 forks source link

<ReactiveBase /> url prop cuts the value #206

Closed kud closed 6 years ago

kud commented 6 years ago

Issue Type: BUG

Description:

I use my component/url prop like this:

      <ReactiveBase
        app="bills,amendments"
        url="https://mydomain.com/api/search/"
      >

However, ReactiveSearch cuts the value of my url by https://mydomain.com which makes a request like https://mydomain.com/bills,amendments which is wrong.

It should do https://mydomain.com/api/search/bills,amendments

To fix it, I have done this:

      <ReactiveBase
        app="/api/search/bills,amendments"
        url="https://mydomain.com"
      >

but it's not obvious in my point of view.

Reactivesearch version: "@appbaseio/reactivesearch": "2.0.0"

Anything else:

URL shouldn't be cut or should accept not only domain name but also path in the url.

metagrover commented 6 years ago

Fixed in 2.2.0 🎉