search

appbaseio / reactivesearch

Search UI components for React and Vue
https://opensource.appbase.io/reactivesearch
Apache License 2.0
4.89k stars 471 forks source link

Documentation for Analytics has wrong default value #2267

Open csepulv opened 7 months ago

csepulv commented 7 months ago

Affected Projects

Library Version: 4.2

Describe the bug

This page notes recordAnalytics defaults to false https://docs.reactivesearch.io/docs/reactivesearch/react/advanced/analytics/#recordanalytics

But the source code has true https://github.com/appbaseio/reactivesearch/blob/37260b5f27512d342e2866f1b89cf546da43cb9c/packages/web/src/components/basic/ReactiveBase.js#L120

Additional context

Please either update the documentation or the source code.It would be preferable to have the source code use false, as indicated in the docs so there are less required props/configs