search

appbaseio / reactivesearch

Search UI components for React and Vue
https://opensource.appbase.io/reactivesearch
Apache License 2.0
4.89k stars 466 forks source link

Support for 'show all' on search? #354

Closed carlopascual closed 6 years ago

carlopascual commented 6 years ago

Issue Type: Enhancement

Platform: Web

Description: It would be nice to have a 'see all results for ${search}'

Screenshots:

image

siddharthlatest commented 6 years ago

One way to handle something like this is giving full control of suggestions rendering. Similar to the onSuggestion prop we added in the past https://github.com/appbaseio/reactivesearch/issues/117, we can support an onAllSuggestions prop.

Giving full JSX control to the user would allow this use-case as well as more specific ones where a custom suggestions display is required.

davidklebanoff commented 6 years ago

@siddharthlatest - That sounds like a good idea. Perhaps using the above feature request as an example of the onSuggestion flexibility. Win win.

carlopascual commented 6 years ago

I'm not sure if I missed it from the documentations, but is there a way to also limit the maximum amount of suggestions that are displayed on search? It would be useful to limit it to be able to make sure that the 'See all results' are seen as well. :)