search

appbaseio / reactivesearch

Search UI components for React and Vue
https://opensource.appbase.io/reactivesearch
Apache License 2.0
4.89k stars 466 forks source link

Bug: Missing onNoResults prop in ResultList / ResultCard #375

Closed siddharthlatest closed 6 years ago

siddharthlatest commented 6 years ago

Issue Type:

Bug

Platform:

ReactiveSearch for Web

Description:

There is a missing prop of onNoResults in the ResultList and ResultCard components. There is a similar prop that exists on ReactiveList component, that should be present in these two as well.

Screenshots:

Minimal reproduction of the problem with instructions:

Reactivesearch version: x.y.z

2.6.4

Browser: [all | Chrome XX | Firefox XX | Edge XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Anything else:

siddharthlatest commented 6 years ago

This works, the issue was with how I was using my theming with ReactiveSearch.