More than 2 suggested categories in categorySearch?

appbaseio / reactivesearch

Search UI components for React and Vue

https://opensource.appbase.io/reactivesearch

Apache License 2.0

4.9k stars 466 forks source link

More than 2 suggested categories in categorySearch? #814

Open iseabock opened 5 years ago

iseabock commented 5 years ago

Issue Type:

I think this falls into the category of enhancement

Platform:

Web

Description:

Is there currently a way, or is it possible for you to add more than just two suggested categories in the categorySearch?

screen shot 2019-02-01 at 4 53 55 pm

metagrover commented 5 years ago

Sounds good. Open to accepting PRs on this.

We can maybe introduce a prop called categorySuggestionsListSize (open to suggestions on the prop name to make it more intuitive)

Refer the code block here for implementation details: https://github.com/appbaseio/reactivesearch/blob/next/packages/web/src/components/search/CategorySearch.js#L693-L703

kvin97 commented 5 years ago

Shall I work on this...I have to work on a contribution to an open source project for an assignment in our university..

jyash97 commented 5 years ago

Hey @kvin97 You can work on this.

kvin97 commented 5 years ago

@jyash97 @metagrover please review the above PR for the added categorySuggestionsListSize prop. Now it can be added as categorySuggestionsListSize={*} in CategorySearch component.