search

appbaseio / reactivesearch

Search UI components for React and Vue
https://opensource.appbase.io/reactivesearch
Apache License 2.0
4.89k stars 466 forks source link

window is not defined (leaflet) #872

Closed ilostit closed 5 years ago

ilostit commented 5 years ago

Hi,

i have this issue after update reactivemaps "@appbaseio/reactivesearch": "^3.0.0-beta.9"

XXX/node_modules/leaflet/dist/leaflet-src.js:7 typeof exports === 'object' && typeof module !== 'undefined' ? factory(exports) : ^ ReferenceError: window is not defined at XXX/node_modules/leaflet/src/core/Util.js:217:24 at version (XXX/node_modules/leaflet/dist/leaflet-src.js:7:65) at Object. (XXX/node_modules/leaflet/dist/leaflet-src.js:10:2) at Module._compile (internal/modules/cjs/loader.js:689:30) at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10) at Module.load (internal/modules/cjs/loader.js:599:32) at tryModuleLoad (internal/modules/cjs/loader.js:538:12) at Function.Module._load (internal/modules/cjs/loader.js:530:3) at Module.require (internal/modules/cjs/loader.js:637:17) at require (internal/modules/cjs/helpers.js:20:18)

any idea ?

metagrover commented 5 years ago

Can you share a codesandbox replicating this issue?

ilostit commented 5 years ago

i will do that, but sorry it's reactiveMaps update not reactiveSearch

metagrover commented 5 years ago

We manage the current version reactivemaps here in this (mono-)repository.

metagrover commented 5 years ago

I'm able to replicate this. Are you running your app in a SSR setup?

ilostit commented 5 years ago

yes that's true :) thanks for your work !!!

metagrover commented 5 years ago

Fixed here: 8a44613 🎉

We will roll out a release with this update including some other SSR and rendering prop upgrades shortly.