avoid O(N) and fix defer reader close

appc / docker2aci

library and CLI tool to convert Docker images to ACIs (archived, see https://github.com/rkt/rkt/issues/4024)

Apache License 2.0

186 stars 60 forks source link

Closed runcom closed 8 years ago

runcom commented 8 years ago

First commit deals with an O(N) routine and removes it (the last layer ID index takes N-1 cycle to be found)
Second commit remove a reader close call because the reader is used after the function returns

cgonyeo commented 8 years ago

LGTM

runcom commented 8 years ago

@dgonyeo reworked the second commit so that if there's an error and the res var isn't nil then we close the body

iaguis commented 8 years ago

One nit but LGTM afterwards.

iaguis commented 8 years ago

Thanks!