appc / docker2aci

library and CLI tool to convert Docker images to ACIs (archived, see https://github.com/rkt/rkt/issues/4024)
Apache License 2.0
186 stars 60 forks source link

repository2: fix manifest v2.2 layer ordering. #190

Closed sgotti closed 8 years ago

sgotti commented 8 years ago

With docker manifest v2.2 and oci the layers are ordered from the base layer to the topmost layer.

This is just a quick fix for review. Next steps will be to add tests and remove duplicated layers.

Fixes #189

lucab commented 8 years ago

I confirm this fixes troublesome containers that we've got reported so far, and LGTM (but I don't have any super-power here).

lucab commented 8 years ago

wrt duplicate layers, @sgotti privately pointed out that https://github.com/docker/distribution/issues/1527 is a relevant reference.