search

appc / docker2aci

library and CLI tool to convert Docker images to ACIs (archived, see https://github.com/rkt/rkt/issues/4024)
Apache License 2.0
186 stars 60 forks source link

Add support for converting OCI tarfiles #200

Closed vishvananda closed 8 years ago

vishvananda commented 8 years ago

This also switches to the new OCI media types.

jonboulle commented 8 years ago

Cool! @dgonyeo do you have any bandwidth for a review?

vishvananda commented 8 years ago

ah good call. I didn't realize the go file object stored the name. Changed it to use that.

cgonyeo commented 8 years ago

I could take a look on Wednesday, scrambling to do a project for school currently

On Sep 26, 2016, at 10:02, Jonathan Boulle notifications@github.com wrote:

Cool! @dgonyeo do you have any bandwidth for a review?

― You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

philips commented 8 years ago

ping @dgonyeo

cgonyeo commented 8 years ago

Wow, so sorry about dropping this. Reviewing now.

vishvananda commented 8 years ago

rebased. Will try rkt tests

vishvananda commented 8 years ago

The unit tests pass fine with the new version. The functional tests are getting a lot of failures but i suspect they fail without my changes as well. It looks like they are failing because i don't have overlayfs enabled on my build machine

vishvananda commented 8 years ago

Ok I manually updated the glide.yaml and glide.lock and used glide install. The hash on the lock file doesn't match anymore, but this means that the update can be done separately after the merge.

cgonyeo commented 8 years ago

Sorry about the couple day delay, was fighting with my setup over something dumb.

LGTM