lib/internal: do not compare tag when pulling by digest

appc / docker2aci

library and CLI tool to convert Docker images to ACIs (archived, see https://github.com/rkt/rkt/issues/4024)

Apache License 2.0

186 stars 60 forks source link

lib/internal: do not compare tag when pulling by digest #207

Closed lucab closed 8 years ago

lucab commented 8 years ago

This commit fixes docker2aci pull-by-digest in order to avoid an improper fallback to "latest" tag and a wrong comparison when no tags have been specified.

Reference: https://github.com/coreos/rkt/issues/2313#issuecomment-245455406

lucab commented 8 years ago

This should have been spotted by TestFetchingByDigestV22, so there is probably another bug to be chased in the testsuite.

/cc @dgonyeo

jonboulle commented 8 years ago

nice catch, lgtm