lib/internal: fix vet errors, and error handling

appc / docker2aci

library and CLI tool to convert Docker images to ACIs (archived, see https://github.com/rkt/rkt/issues/4024)

Apache License 2.0

186 stars 60 forks source link

lib/internal: fix vet errors, and error handling #210

Closed s-urbaniak closed 8 years ago

s-urbaniak commented 8 years ago

This introduces go vet, and fixes error handling in backend/file.

Fixes #194

s-urbaniak commented 8 years ago

Unfortunately go 1.6.3 (the version we are building with on Semaphor) has a bug with struct literals, and slices, as reported in https://github.com/golang/go/issues/9171. So I am tempted to disable these go vet tests now at all :-/

Another possibility: we bump go 1.7 in Semphore.

s-urbaniak commented 8 years ago

Nevermind, I found a way to trick it.

s-urbaniak commented 8 years ago

@jonboulle addressed review comments, PTAL

jonboulle commented 8 years ago

LGTM, thanks!