search

appc / spec

App Container Specification and Tooling (archived, see https://github.com/rkt/rkt/issues/4024)
Apache License 2.0
1.26k stars 146 forks source link

spec/ace: Specify Content-Type for metadata service. #677

Closed uiri closed 8 years ago

uiri commented 8 years ago

Some of the metadata service endpoints explicitly specify a Content-Type of text/plain; charset=us-ascii. For most other endpoints, the ACE validator expects a Content-Type of application/json.

The one exception is the HMAC verify endpoint which makes no mention of its Content-Type nor even the contents of its response body. The current implementation in rkt sets the Content-Type to text/plain; charset=us-ascii which is now reflected in the spec.

jonboulle commented 8 years ago

LGTM, thanks (I was wondering whether these should be in backticks, as you've done in the commit message, but can see arguments either way, so will leave it for now - feel free to follow up if you want to change that).