appcanary / agent

The Appcanary agent
https://www.appcanary.com
GNU General Public License v3.0
47 stars 6 forks source link

Bug in detect_linux.sh #134

Closed mveytsman closed 7 years ago

mveytsman commented 7 years ago

https://github.com/appcanary/agent/blob/9b4b5acfb5d8becd63ef1ab6843e1cd9e20a8958/agent/resources/detect_linux.sh#L25

detect_linux assumes that /etc/lsb-release actually contains DISTRIB_ID and DISTRIB_RELEASE.

We need to check that those variables are defined and continue to the next test if they aren't.

A customer had a centos release that had some other stuff in /etc/lsb-release, which caused our detection script to fail.