search

appcanary / agent

The Appcanary agent
https://www.appcanary.com
GNU General Public License v3.0
47 stars 6 forks source link

Support CentOS Upgrades #136

Closed j0ni closed 7 years ago

j0ni commented 7 years ago

This seems to "just work" with the values supplied by the existing process. Couple things:

  1. The map provided as packageList appears to contain package/version pairs where the version contains the entire package name plus a .rpm suffix.
  2. I'm not doing any metadata update (a la apt-get update) because I don't see how yum does that. It seems to sync as part of other operations.
  3. I'm not dealing with conflicts or configuration stomping. I need to investigate that a bit.

This is mergeable without regression, but let's discuss at least point number 3 above.

phillmv commented 7 years ago

the version contains the entire package name plus a .rpm suffix.

We deal with this in the backend - rpm versions usually have the .rpm suffix - but if you're telling me that yum will accept

yum update-to --assume-yes foobar-1.2.3-el7.rpm

then that seems acceptable to me.

I'm not dealing with conflicts or configuration stomping. I need to investigate that a bit.

OK, to be determined.

I noticed you stomped out my underscore rebellion against camelCase ;). This PR seems just fine to me.