search

appcanary / agent

The Appcanary agent
https://www.appcanary.com
GNU General Public License v3.0
47 stars 6 forks source link

Touch and chown /var/log/appcanary.log #86

Closed MacLeodMike closed 9 years ago

MacLeodMike commented 9 years ago

Should resolve #85

phillmv commented 9 years ago

Do you understand how test/pkg works to add this as a test there?

On Jul 18, 2015, at 09:30, MacLeodMike notifications@github.com wrote:

Should resolve #85

You can view, comment on, or merge this pull request online at:

https://github.com/appcanary/agent/pull/86

Commit Summary

Touch and chown /var/log/appcanary.log File Changes

M package/amazon/2015.03/post-install.sh (2) M package/centos/6/post-install.sh (2) M package/centos/7/post-install.sh (2) M package/debian/jessie/post-install.sh (2) M package/debian/wheezy/post-install.sh (2) M package/redhat/6/post-install.sh (2) M package/redhat/7/post-install.sh (2) M package/ubuntu/precise/post-install.sh (2) M package/ubuntu/trusty/post-install.sh (2) M package/ubuntu/vivid/post-install.sh (2) Patch Links:

https://github.com/appcanary/agent/pull/86.patch https://github.com/appcanary/agent/pull/86.diff — Reply to this email directly or view it on GitHub.

MacLeodMike commented 9 years ago

I still get a big ol' fail when trying 'rake integration:everything'. There must be something missing from my environment, but I'm not sure what.

MacLeodMike commented 9 years ago

I pulled the logfile from CONFIG_FILES, and we're now depending on the post-install.sh to create it. I think this is preferable - log files really aren't the same as log files, and the same logic should not be applied. For example, when upgrading the package I shouldn't be prompted whether to install the new logfile from the maintainer.

On a practical level, when it was created via CONFIG_FILES it would always be set to root:root, after the post-install.sh ran.

phillmv commented 9 years ago

The test should also confirm that the right perms got set :).

Also do the tests pass? You didn't increment the OKAC counter so these should all fail no?

On Jul 19, 2015, at 09:51, MacLeodMike notifications@github.com wrote:

I pulled the logfile from CONFIG_FILES, and we're now depending on the post-install.sh to create it. I think this is preferable - log files really aren't the same as log files, and the same logic should not be applied. For example, when upgrading the package I shouldn't be prompted whether to install the new logfile from the maintainer.

On a practical level, when it was created via CONFIG_FILES it would always be set to root:root, after the post-install.sh ran.

— Reply to this email directly or view it on GitHub.

phillmv commented 9 years ago

This is good and technically correct but not an answer for #85 ;). I think that'll have to be a code change.