search

appcanary / appcanary.rb

3 stars 0 forks source link

Address review issues and improve docs #16

Closed j0ni closed 7 years ago

j0ni commented 7 years ago

This closes #10, #11, #12, #14 and #15.

Also, I moved the class methods for the client to the outer namespace as we discussed but didn't make an issue for.

phillmv commented 7 years ago

Woops, i may have clicked no the wrong review interface.

j0ni commented 7 years ago

@phillmv I think it just resulted in you "requesting changes", but I find it pretty confusing myself now.

phillmv commented 7 years ago

This is great, btw! Quite liked how much you pulled together in how little time it too you :D

j0ni commented 7 years ago

OK, I think we're finally on the same page @phillmv, lemme know if not.

Also, this frickin github review UX is weird and I have no idea how to work it. We should have a special tutorial video viewing party or something, because I don't feel qualified to "dismiss review" or even have a clue what the semantics of "dismiss review" are.

j0ni commented 7 years ago

Going to merge this in a little while in the interests of moving along.

phillmv commented 7 years ago

lgtm