search

appcelerator-archive / amp

** THIS PROJECT IS STOPPED ** An open source CaaS for Docker, batteries included.
http://appcelerator.io
Apache License 2.0
81 stars 28 forks source link

Improper use of user's home directory for storing settings #1153

Closed subfuzion closed 7 years ago

subfuzion commented 7 years ago

Various services are storing configuration settings in the user's home directory under ~/.config, creating root-owned directories (including ~/.config itself if it didn't already exist). These subdirectories include amp and infrakit and files like amplifier.yml.

We should stick to appropriate FHS conventions as much as possible. For example, we should consider storing static application files in /opt/amp and variable data in /var/opt/amp.

ndegory commented 7 years ago

it used to be the case with our earlier experiments on InfraKit, but I think we got rid of all those ~/.config/ folders (it now runs in a container, with a data volume mounted on /infrakit). Did you notice it recently?

subfuzion commented 7 years ago

It could be a left over artifact, but nevertheless, my main point is to ensure we clean up anything that is creating/storing any data under home that isn't based on the user's personal CLI preferences.

subfuzion commented 7 years ago

The directory was created for ~/.config/infrakit/certs two and a half weeks ago. It's good that we're no longer doing that for infrakit. We need to update amplfier and ensure everyone is aware going forward.

ndegory commented 7 years ago

I see, it may still happen for this particular folder, we don't need it anymore so I'll remove that code.

bquenin commented 7 years ago

Fixed by #1175