search

appcelerator-archive / windowslib

This is a library of utilities for dealing programmatically with Windows Phone applications, used namely for tools like Titanium.
http://www.appcelerator.com
Other
4 stars 10 forks source link

[TIMOB-23748] Failed to connect to WP 8.1 device #50

Closed infosia closed 8 years ago

infosia commented 8 years ago

TIMOB-23748

Titanium CLI is unable to connect to Windows Phone 8.1 device after updating to Microsoft Windows 10 SDK 10.0.14393. There's no problem building against Windows 10 Mobile device though.

vs

As far as I can see, it turns out that Microsoft.SmartDevice.Connectivity.IDevice.GetEndPoints throws Exception when you connect to Windows Phone 8.1 device. I found that it actually is able to connect to WP 8.1 device, and those information (that IDevice.GetEndPoints collects) are not actually used from Titanium CLI, so it's safe to return success=true.

garymathews commented 8 years ago

@infosia Since this is the same problem for Windows 10 devices wptool.cs#L179 we could remove the Windows 10 if statement and let it fall into the catch OR amend the if for Windows 8.1 devices, saving time by not waiting on connectableDevice.Connect(); ?

infosia commented 8 years ago

@garymathews Yeah makes sense. I would remove the Windows 10 if statement and let it fall into the catch. I'll push it soon.

garymathews commented 8 years ago

CR: PASS FR: PASS