search

appcelerator-archive / windowslib

This is a library of utilities for dealing programmatically with Windows Phone applications, used namely for tools like Titanium.
http://www.appcelerator.com
Other
4 stars 10 forks source link

Use VsDevCmd instead of vcvarsall #66

Closed infosia closed 7 years ago

infosia commented 7 years ago

TIMOB-24189

I found interesting behavior while working on https://github.com/appcelerator/titanium_mobile_windows/pull/959, that is some VS batch tools (including vcvarsall.bat) does not work correctly when it is executed by 8.3 filenames. We are usually using 8.3 filename when requiring vcvarsall.bat but it seems it does not work correctly under the situation. I'm also thinking that we should use VsDevCmd.bat instead because it's the file that Visual Studio Developer Console is using. We can safely replace it because VsDevCmd.bat is available as of Visual Studio 2012.

infosia commented 7 years ago

Maybe we should add this as a path in windowslib (vsInfo.vsDevCmd) so we only need to maintain it in one place?

Makes sense. Updated.

garymathews commented 7 years ago

CR: PASS FT: PASS

👍