search

appcelerator-developer-relations / Sample.Todo

Titanium Mobile todo sample app
Other
35 stars 30 forks source link

[TIMOB-19057] Add Windows support #17

Closed infosia closed 9 years ago

infosia commented 9 years ago

[TIMOB-19057]

This is to make the sample work on Windows. Should work once https://github.com/appcelerator/titanium_mobile_windows/pull/370 is merged.

garymathews commented 9 years ago

@infosia I can only mark one item as done. When selecting other items I don't get a prompt. Also the text box when adding an item is scaled so it is off screen.

infosia commented 9 years ago

@garymathews Fix for prompt issue: TIMOB-19219.

The width issue for the components are because of width: '300dp'. Actual pixel calculation are done around UI/src/WindowsViewLayoutDelegate.cpp#L841, looks like 300dp is too big. Do you think we need to do like this? 

width: isWindowsPhone ? '200dp' : '300dp`,
garymathews commented 9 years ago

Yes, that's what I've done in Geocoder. Although I still don't think the scaling is correct. Why should we need to use a different dp on Windows Phone? I think I'll take another look at scaling.

garymathews commented 9 years ago

I've tested it using the latest titanium_mobile_windows build. After adding the first item the buttons in any additional prompts don't work.

infosia commented 9 years ago

Pushed a fix for it: https://github.com/appcelerator/titanium_mobile_windows/pull/378

garymathews commented 9 years ago

CR: PASS FR: PASS