search

appcues / appcues-android-sdk

The Appcues Android SDK
https://www.appcues.com/mobile
MIT License
10 stars 3 forks source link

🐛 Fix to React Native RTL #558

Closed andretortolano closed 9 months ago

andretortolano commented 9 months ago

Experience was not showing because the composition was losing state, I still did not figure out what exactly made so the experience was stuck, but it was related to how React Native keeps "refreshing" the layout direction, so by adding LayoutDirection.current to the main key clause we ensure to re-compose from scratch when a new value is passed in.

shortcut-integration[bot] commented 9 months ago

This pull request has been linked to Shortcut Story #62420: [Android] - RTL minor adjustments.

andretortolano commented 9 months ago

what was observed is that the Composition is losing state, I imagine the flags "contentVisible" and "backdropVisible" makes so the experience never shows. on further testing I was able to render single compositions in the same scenario, so its an issue related to our Composition and its states for sure.