appcues / appcues-android-sdk

The Appcues Android SDK
https://www.appcues.com/mobile
MIT License
10 stars 3 forks source link

ModalStateMachineOwner.onUiIdle java.lang.OutOfMemoryError com.appcues.ui ModalStateMachineOwner.kt:116 #616

Closed mahmed1987 closed 5 months ago

mahmed1987 commented 6 months ago

We get this crash in our production app for a few devices.

I have printed the stacktrace below

image

This is the OS breakdown of the crash

image

This is the device breakdown

image
iujames commented 6 months ago

Hi @mahmed1987 , thank you for letting us know about this issue. We believe it is possible that the use of a Timer could be leading to memory issues in some cases. One idea we have is to change this to use a coroutine and a delay - @andretortolano proposed this change in #617 if you have any feedback to share on that approach. Thanks!

mahmed1987 commented 6 months ago

@iujames thanks for quick resolution of the issue . Any idea when this fix would be included in your release cycle ?

andretortolano commented 6 months ago

hey @mahmed1987 we plan on doing a small patch that include the fix this afternoon

iujames commented 6 months ago

@mahmed1987 confirming that @andretortolano did release the 3.1.14 version yesterday, with this update, and you should see that available now in Maven Central. Thank you @andretortolano !

mahmed1987 commented 6 months ago

Thanks a bunch good folks. I hope this would resolve the situation. Will update our app with the new dependency and wait for the results

mahmed1987 commented 6 months ago

@iujames I forgot to mention that i am using the the appcues dependency through segment

I am using this to include the appcues sdk in the code

com.appcues:segment-appcues:3.1.14.

I guess 3.1.14 must be available for com.appcues:appcues but for the above dependency with segment I get the error

"Caused by: org.gradle.internal.resolve.ModuleVersionNotFoundException: Could not find com.appcues:segment-appcues:3.1.14. " during dependency resolution .

iujames commented 6 months ago

@mahmed1987 got it, thank you for this additional info. We can update our Segment plugin to match, today.

iujames commented 6 months ago

@mahmed1987 the Appcues-Segment plugin version 3.1.14 update has been published with this change https://github.com/appcues/segment-appcues-android/releases/tag/3.1.14 - available in Maven Central now.