To not lose the message when encoding properties, I'm passing the logging instance through to the encoder from the Activity and Event models. I'm not the biggest fan of doing this, but I think it's worthwhile (and the parameter is optional).
I have a subsequent PR lined op that makes a generic Logging protocol that will let us intercept the logs to show in the debugger and test the log messages that get generated.
To be as safe as possible, remove places where
assertionFailurewould cause a crash in-Ononedebug builds (https://developer.apple.com/documentation/swift/assertionfailure(_:file:line:)).To not lose the message when encoding properties, I'm passing the logging instance through to the encoder from the
ActivityandEventmodels. I'm not the biggest fan of doing this, but I think it's worthwhile (and the parameter is optional).I have a subsequent PR lined op that makes a generic
Loggingprotocol that will let us intercept the logs to show in the debugger and test the log messages that get generated.